Adding blurhash to image_details. #5227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is now available in pictrs v0.5.17-pre.8 |
dessalines
requested review from
phiresky,
dullbananas,
Nutomic and
SleeplessOne1917
as code owners
|
K I updated to that pictrs, and tested this manually. Its correctly setting the blurhash DB column for uploaded images. I'm not sure whether to have a default blurhash, or just leave it as is with the blurhash column optional. Proxied images can't get blurhashes anyway, only uploaded ones can, so its probably fine to leave optional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving this as draft until a new version of pictrs is released, with blurhash, and tests can be added.
The actual response from pictrs is
blurhash: String, but we should leave this as an option for at least a few versions, in order to not break image details running older pictrs versions.