Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase alt text size #4724

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

flamingo-cant-draw
Copy link
Contributor

300 characters isn't enough, this increases it to be the same as Mastodon.

Copy link
Member

@SleeplessOne1917 SleeplessOne1917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. I'm gonna wait for some of the other maintainers' opinions on this before merging.

@Nutomic
Copy link
Member

Nutomic commented May 17, 2024

For reference here is a text with 300 characters:

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Etiam eu lorem nisl. Aliquam nunc arcu, convallis nec neque mattis, hendrerit dictum justo. Cras cursus vitae elit non accumsan. Maecenas consequat facilisis elit id gravida. Duis tempus pretium molestie. Donec finibus libero in tellus posuer

And here 1500:

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Etiam eu lorem nisl. Aliquam nunc arcu, convallis nec neque mattis, hendrerit dictum justo. Cras cursus vitae elit non accumsan. Maecenas consequat facilisis elit id gravida. Duis tempus pretium molestie. Donec finibus libero in tellus posuere, in suscipit ex tempor. Duis eget est purus. Praesent malesuada condimentum urna. Mauris magna elit, pulvinar at lacinia sed, viverra sed dui. Nullam sit amet aliquam nulla. Morbi lobortis leo non magna molestie, et tincidunt ex elementum. Donec lacinia turpis ligula, vitae sollicitudin nisl consectetur vitae. Nunc consequat, massa eget vulputate gravida, ipsum libero tempor turpis, ut pulvinar ligula enim vitae felis. Vestibulum et felis velit. Orci varius natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Suspendisse non metus maximus purus euismod iaculis. Duis tincidunt vestibulum ipsum. Fusce vulputate congue nisl semper semper. Aliquam vitae tellus ac eros ullamcorper sodales at volutpat nisl. Mauris suscipit leo vel tellus faucibus, ut posuere neque commodo. Morbi in finibus neque. Sed aliquam dignissim lacus, eu dignissim nulla mollis quis. Fusce commodo, eros vel facilisis rhoncus, elit eros aliquet orci, quis malesuada sem massa id ligula. Duis non tellus pulvinar, auctor elit posuere, pharetra ipsum. Nunc bibendum mollis elit, eu luctus enim gravida sit amet. Sed fringilla eros ut risus semper tempus. Ut neque dui, ullamcorper ut pharetra sed ve

That seems way too long to describe an image, and I bet many apps/frontends wont have space to display it properly.

Copy link
Collaborator

@dullbananas dullbananas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful for images that contain text

@SleeplessOne1917
Copy link
Member

Maybe 500 would be better?

In iaculis mollis mattis. Nam rutrum posuere purus, quis volutpat dolor auctor quis. Maecenas magna sem, imperdiet ut accumsan nec, sollicitudin sit amet lorem. Ut porta magna commodo felis vehicula hendrerit. In luctus ornare consequat. Cras laoreet consequat velit et imperdiet. Aliquam eu placerat lorem. Phasellus eget nisi magna. Integer sapien mi, interdum et condimentum vitae, venenatis eget leo. Integer eleifend varius imperdiet. In sit amet efficitur enim. Proin sollicitudin orci aliquam.

Perhaps 750?

Cras semper nisi sed augue dapibus posuere. In ullamcorper sollicitudin bibendum. Aliquam ornare porttitor elit ut varius. Vivamus gravida gravida orci. Curabitur faucibus eu felis vel mattis. Sed mattis iaculis sapien quis hendrerit. Nulla accumsan gravida sapien, id facilisis tortor varius sit amet. Maecenas commodo quam nec massa laoreet aliquam. Nunc euismod placerat dui, id efficitur risus aliquam consectetur. Sed in lobortis sapien, vitae mattis nisl. Sed lorem turpis, aliquet ac leo nec, consectetur congue ex. Nulla imperdiet quam in tempus aliquam. Nunc sapien tellus, faucibus a nisi non, fermentum vulputate purus. Vestibulum sed nulla a nisl ultricies cursus vitae a risus. Etiam cursus nisl dolor. Aliquam a nibh felis. Quisque dui.

@flamingo-cant-draw
Copy link
Contributor Author

I bet many apps/frontends wont have space to display it properly.

Most Mastodon apps handle it fine, e.g. here's Moshidon:

Screenshot from Moshidon showing post with a long alt text

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget why I chose 300, but ya I agree it makes sense especially for image posts with a LOT of text to have this larger. Maybe not 10k like the post body, but this seems fine for now.

@dessalines dessalines merged commit a0ad780 into LemmyNet:main May 17, 2024
1 check passed
@flamingo-cant-draw flamingo-cant-draw deleted the alt-text-size branch May 24, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants