Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Hotfix 2024-10-31 #8261

Merged
merged 6 commits into from
Oct 31, 2024
Merged

🔥 Hotfix 2024-10-31 #8261

merged 6 commits into from
Oct 31, 2024

Conversation

live-github-bot[bot]
Copy link
Contributor

Next release is on the way 🚀!

This pull request aims to fix a bug in production for a Ledger Live product.

Checklist

To be ready to be merged, we must comply with all theses checks:

  • changelogs are included with description about the bug(s)
  • all CI checks have passed
  • reviewed by QA
  • hotix is reviewed by the Delivery Team

⚠️ If this hotfix targets Ledger Live Desktop

  • RELEASE_NOTES.md has been updated

Once all these checks are validated, the pull request can be merged using the correct workflow.

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 4:33pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 4:33pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 4:33pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 4:33pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 4:33pm

@live-github-bot
Copy link
Contributor Author

live-github-bot bot commented Oct 31, 2024

Desktop Bundle Checks

Comparing e9f5f01 against cd686cf.

🚀 main bundle size decreased (1.8mb -> 1.7mb). Thanks ❤️
⚠️ semver library is now duplicated in main (regression)
⚠️ universalify library is now duplicated in main (regression)
⚠️ @babel/runtime/helpers/extends library is now duplicated in renderer (regression)
⚠️ @babel/runtime/helpers/interopRequireDefault library is now duplicated in renderer (regression)
⚠️ @babel/runtime/regenerator library is now duplicated in renderer (regression)
⚠️ @babel/runtime/helpers/asyncToGenerator library is now duplicated in renderer (regression)
⚠️ @babel/runtime/helpers/possibleConstructorReturn library is now duplicated in renderer (regression)
⚠️ @babel/runtime/helpers/getPrototypeOf library is now duplicated in renderer (regression)
⚠️ @babel/runtime/helpers/esm/extends library is now duplicated in renderer (regression)
⚠️ @babel/runtime/helpers/esm/typeof library is now duplicated in renderer (regression)
⚠️ @babel/runtime/helpers/esm/defineProperty library is now duplicated in renderer (regression)
⚠️ @babel/runtime/helpers/esm/classCallCheck library is now duplicated in renderer (regression)
⚠️ @babel/runtime/helpers/esm/createClass library is now duplicated in renderer (regression)
⚠️ @babel/runtime/helpers/esm/inherits library is now duplicated in renderer (regression)
⚠️ @babel/runtime/helpers/esm/createSuper library is now duplicated in renderer (regression)
⚠️ @babel/runtime/helpers/esm/inheritsLoose library is now duplicated in renderer (regression)
⚠️ @babel/runtime/helpers/esm/assertThisInitialized library is now duplicated in renderer (regression)
🚀 mime-db library is no longer duplicated in main
🚀 @ledgerhq/devices library is no longer duplicated in main

Mobile Bundle Checks

Comparing 2c9b8ae against 3fad47a.

✅ Previous issues have all been fixed.

sarneijim
sarneijim previously approved these changes Oct 31, 2024
KVNLS
KVNLS previously approved these changes Oct 31, 2024
Wozacosta
Wozacosta previously approved these changes Oct 31, 2024
@KVNLS KVNLS dismissed stale reviews from Wozacosta, cgrellard-ledger, sarneijim, and themself via a636710 October 31, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants