Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QAA-312][DETOX] Speculos add accounts tests #8186

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

[QAA-312][DETOX] Speculos add accounts tests #8186

wants to merge 13 commits into from
+429 −195

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Oct 24, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached. (no need)
  • Covered by automatic tests.
  • Impact of the changes:
    • LLM E2E Tests

📝 Description

Improving LLM Detox x Speculos :

  • Disable speculos iOS Speculos tests as not supported on CI yet
  • Making enums LLD common to use in LLM
  • Creating a DETOX env to decouple flakiness related changes from MOCKed tests
  • Fixing speculos destroy to wait for it before continuing
  • Improving Speculos add account test
  • Separate each coin by file to enable parallelisation
  • Fixing iOS caching to take into account .env.mock file

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Oct 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 5:56pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 5:56pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 5:56pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 5:56pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 5:56pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common automation CI/CD stuff cli labels Oct 24, 2024
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_312_detox_speculos_add_accounts branch from f32e399 to bbee91c Compare October 24, 2024 17:08
@live-github-bot live-github-bot bot removed the cli label Oct 24, 2024
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_312_detox_speculos_add_accounts branch 10 times, most recently from 4a8ac61 to ebd358e Compare October 31, 2024 09:33
@abdurrahman-ledger abdurrahman-ledger changed the title [DRAFT][QAA-312][DETOX] Speculos add accounts tests [QAA-312][DETOX] Speculos add accounts tests Oct 31, 2024
@abdurrahman-ledger abdurrahman-ledger marked this pull request as ready for review October 31, 2024 09:36
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_312_detox_speculos_add_accounts branch 2 times, most recently from 52d1bdd to 05dbffd Compare October 31, 2024 10:06
@abdurrahman-ledger
Copy link
Contributor Author

PR checks are all green with correct workflow from this branch

ypolishchuk-ledger
ypolishchuk-ledger reviewed Oct 31, 2024
View reviewed changes
apps/ledger-live-mobile/e2e/page/accounts/addAccount.drawer.ts Outdated Show resolved Hide resolved
apps/ledger-live-mobile/e2e/page/accounts/account.page.ts Show resolved Hide resolved
apps/ledger-live-mobile/e2e/specs/speculos/addAccount/AddAccount.ts Outdated Show resolved Hide resolved
apps/ledger-live-mobile/e2e/specs/speculos/addAccount/AddAccountADA.spec.ts Show resolved Hide resolved
apps/ledger-live-mobile/e2e/specs/speculos/addAccount/AddAccountALGO.spec.ts
import { runAddAccountTest } from "./AddAccount";
import { Currency } from "@ledgerhq/live-common/e2e/enum/Currency";

runAddAccountTest(Currency.ALGO, "B2CQA-2497, B2CQA-2653, B2CQA-2681");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when your PR is merged can you please update all affected tickets from regression scope to have "Automated on:" "LLM (Detox)"? or you maybe can do it even now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_312_detox_speculos_add_accounts branch 2 times, most recently from a29ab53 to 43b3050 Compare October 31, 2024 15:38
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_312_detox_speculos_add_accounts branch from 43b3050 to 4ff0562 Compare October 31, 2024 16:25
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_312_detox_speculos_add_accounts branch from 4ff0562 to 78302cb Compare October 31, 2024 17:16
@abdurrahman-ledger
Copy link
Contributor Author

PR Checks are all green with correct LLM iOS E2E Tests workflow from this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

@bharamboure-ledger bharamboure-ledger bharamboure-ledger left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@abdurrahman-ledger abdurrahman-ledger

Labels
automation CI/CD stuff common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdurrahman-ledger @ypolishchuk-ledger @bharamboure-ledger