fix(lld): auto scroll when mounted on accounts page #6860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: apps/ledger-live-desktop/src/renderer/screens/accounts/AccountRowItem/index.tsx
Did you find this useful? React with a 👍 or 👎 |
LucasWerey
commented
May 15, 2024
| @@ -145,7 +145,13 @@ const AccountRowItem = (props: Props) => { | |||
|
|
|||
| const scrollTopFocusRef = useRef<HTMLSpanElement>(null); | |||
|
|
|||
| const mountedRef = useRef(true); | |||
There was a problem hiding this comment.
This will disable the auto scroll but in DEV every changes done on the page in the code will result in an auto scroll to the last account
gre
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
A regression has been introduced to automatically scroll account pages to the bottom of the page.
❓ Context
🧐 Checklist for the PR Reviewers