Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common/listApps): custom lock screen size for all compatible models #6856

Merged
merged 3 commits into from
May 20, 2024

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented May 14, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Storage computation on Europa devices.

πŸ“ Description

On Europa, the custom lock screen size in storage wasn't taken into account in the computation, therefore giving wrong informations about available storage space, and for instance letting the user try to install an app while there is actually so space available for this app.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 17, 2024 8:05am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 8:05am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 8:05am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 8:05am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 8:05am

@ofreyssinet-ledger ofreyssinet-ledger merged commit db77ae6 into develop May 20, 2024
60 of 62 checks passed
@ofreyssinet-ledger ofreyssinet-ledger deleted the bugfix/LIVE-12411-europa-cls-storage branch May 20, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants