-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LIVE-12852] Bugfix - Extend expired time for TRC20 #6852
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ 5 Ignored Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated based on code, but requires QA validation before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still requires manual testing for the Live side for non regression
CI is completely red so removing my review for now
3ebfafc
to
b8281fe
Compare
b8281fe
to
acd397b
Compare
β Checklist
npx changeset
was attached.π Description
Following Tron PR https://github.com/LedgerHQ/ledger-live/pull/3783/files, Vault support TRC20 as well now. But simillar to before, Tr20 transaction had to be signed in 30 seconds. Ledger Vault takes more time to approve, especially if the transaction requires multiple approvals.
Also adds the
SKIP_ONBOARDING
env variable to thehasCompletedOnboardingSelector
of LLD to skip the onboarding for Vault users.β Context
Vault client are unable to perform TRC20 tx because they can not approve a tx in 30 seconds
π§ Checklist for the PR Reviewers