Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend expired time for trc20 #6852

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

extend expired time for trc20 #6852

wants to merge 7 commits into from
+8 −3

Conversation

drakoFukayu
Copy link
Contributor

@drakoFukayu drakoFukayu commented May 14, 2024 •
edited by ben778899

✅ Checklist

  • npx changeset was attached.
  • atomic delivery
  • No breaking change: same as what was done for tron
    • ...

📝 Description

Following Tron PR https://github.com/LedgerHQ/ledger-live/pull/3783/files, Vault support TRC20 as well now. But simillar to before, Tr20 transaction had to be signed in 30 seconds. Ledger Vault takes more time to approve, especially if the transaction requires multiple approvals.

Also adds the SKIP_ONBOARDING env variable to the hasCompletedOnboardingSelector of LLD to skip the onboarding for Vault users.

❓ Context

Vault client are unable to perform TRC20 tx because they can not approve a tx in 30 seconds

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented May 14, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 8:02am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 31, 2024 8:02am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 31, 2024 8:02am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 31, 2024 8:02am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 31, 2024 8:02am

@live-github-bot live-github-bot bot added the common Has changes in live-common label May 14, 2024
lambertkevin
lambertkevin previously approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@lambertkevin lambertkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated based on code, but requires QA validation before merge

@drakoFukayu drakoFukayu marked this pull request as ready for review May 17, 2024 10:38
@drakoFukayu drakoFukayu requested a review from a team as a code owner May 17, 2024 10:38
@lambertkevin lambertkevin requested a review from a team as a code owner May 23, 2024 09:39
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label May 23, 2024
gre
gre requested changes May 23, 2024
View reviewed changes
libs/env/src/env.ts Outdated Show resolved Hide resolved
lambertkevin
lambertkevin previously approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@lambertkevin lambertkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still requires manual testing for the Live side for non regression

@lambertkevin lambertkevin dismissed their stale review May 31, 2024 08:41

CI is completely red so removing my review for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gre gre gre approved these changes

@lambertkevin lambertkevin lambertkevin left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@drakoFukayu drakoFukayu

Labels
common Has changes in live-common desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@drakoFukayu @gre @lambertkevin @flocks