Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-12852] Bugfix - Extend expired time for TRC20 #6852

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

drakoFukayu
Copy link
Contributor

@drakoFukayu drakoFukayu commented May 14, 2024

βœ… Checklist

  • npx changeset was attached.
  • atomic delivery
  • No breaking change: same as what was done for tron
    • ...

πŸ“ Description

Following Tron PR https://github.com/LedgerHQ/ledger-live/pull/3783/files, Vault support TRC20 as well now. But simillar to before, Tr20 transaction had to be signed in 30 seconds. Ledger Vault takes more time to approve, especially if the transaction requires multiple approvals.

Also adds the SKIP_ONBOARDING env variable to the hasCompletedOnboardingSelector of LLD to skip the onboarding for Vault users.

❓ Context

Vault client are unable to perform TRC20 tx because they can not approve a tx in 30 seconds


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 10:51am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 10:51am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 10:51am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 10:51am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 10:51am

lambertkevin
lambertkevin previously approved these changes May 14, 2024
Copy link
Contributor

@lambertkevin lambertkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated based on code, but requires QA validation before merge

libs/env/src/env.ts Outdated Show resolved Hide resolved
gre
gre previously approved these changes May 31, 2024
lambertkevin
lambertkevin previously approved these changes May 31, 2024
Copy link
Contributor

@lambertkevin lambertkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still requires manual testing for the Live side for non regression

@lambertkevin lambertkevin dismissed their stale review May 31, 2024 08:41

CI is completely red so removing my review for now

@lambertkevin lambertkevin force-pushed the feat/increate-trc20-expired-time branch from 3ebfafc to b8281fe Compare June 4, 2024 10:41
@lambertkevin lambertkevin changed the title extend expired time for trc20 [LIVE-12852] Bugfix - Extend expired time for TRC20 Jun 4, 2024
@lambertkevin lambertkevin force-pushed the feat/increate-trc20-expired-time branch from b8281fe to acd397b Compare June 4, 2024 10:50
@lambertkevin lambertkevin self-assigned this Jun 4, 2024
@lambertkevin lambertkevin merged commit 48ac131 into develop Jun 4, 2024
62 of 71 checks passed
@lambertkevin lambertkevin deleted the feat/increate-trc20-expired-time branch June 4, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants