-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hw-trustchain library + trustchain library bootstrap #6836
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
4 Ignored Deployments
|
New and removed dependencies detected. Learn more about Socket for GitHub βοΈ
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be great to start organizing those libraries in other sub directory, instead of having everything in /libs
(ledgerjs syndrome) ;)
09aa7dd
to
00ca06d
Compare
@sprohaszka-ledger mmh not sure. I like it flattened. and i would actually have preferred ledgerjs libs to be flat in the /libs too, because then it's easy to just find the library. at the end of the day, a library is global (in the package.json / in the dep management) and it's also confusing for devs that |
@gre, I find it hard to navigate and understand what part of the code base are meaningful together. But I think this is another topic, not related to this PR |
@sprohaszka-ledger i see. actually i see it could make sense to group libs per team ownership. would help on the codeowners too |
β Checklist
npx changeset
was attached. no need to.π Description
hw-trustchain
library implementation (original code author: @pollastri-pierre) on the monorepo./trustchain
:trustchain
package that will be the home for the next iteration.β Context
big picture https://ledgerhq.atlassian.net/wiki/spaces/WXP/pages/4717314137/2024-05-17+technical+breakdown+of+core+tasks+and+architecture
π§ Checklist for the PR Reviewers