Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hw-trustchain library + trustchain library bootstrap #6836

Merged
merged 1 commit into from
May 21, 2024

Conversation

gre
Copy link
Contributor

@gre gre commented May 10, 2024

βœ… Checklist

  • npx changeset was attached. no need to.
  • Covered by automatic tests.
  • Impact of the changes:
    • no impact. we just introduce a library.

πŸ“ Description

  • Create hw-trustchain library implementation (original code author: @pollastri-pierre) on the monorepo.
  • This is the client bindings for the Nano app https://github.com/LedgerHQ/app-trustchain.
  • βœ… This was tested manually on Electron and React Native that the library is ready for it (that the crypto curves are working there)
  • βœ… it also works on the web (had to activate wasm)
  • βœ… a basic button was implemented on the Web Tools /trustchain :

Capture d’écran 2024-05-17 aΜ€ 17 21 56

  • Bootstrap trustchain package that will be the home for the next iteration.

❓ Context

big picture https://ledgerhq.atlassian.net/wiki/spaces/WXP/pages/4717314137/2024-05-17+technical+breakdown+of+core+tasks+and+architecture


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 21, 2024 10:13am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 10:13am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 10:13am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 10:13am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 10:13am

Copy link

socket-security bot commented May 10, 2024

New and removed dependencies detected. Learn more about Socket for GitHub β†—οΈŽ

Package New capabilities Transitives Size Publisher
npm/@ledgerhq/[email protected] None 0 0 B
npm/@ledgerhq/[email protected] None 0 0 B
npm/[email protected] None +4 909 kB junderw
npm/[email protected] filesystem +1 233 kB junderw

View full reportβ†—οΈŽ

@gre gre requested a review from a team as a code owner May 16, 2024 13:58
Copy link
Contributor

@sprohaszka-ledger sprohaszka-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be great to start organizing those libraries in other sub directory, instead of having everything in /libs (ledgerjs syndrome) ;)

@gre gre force-pushed the support/trustchain branch 4 times, most recently from 09aa7dd to 00ca06d Compare May 16, 2024 14:35
@gre
Copy link
Contributor Author

gre commented May 16, 2024

@sprohaszka-ledger mmh not sure. I like it flattened. and i would actually have preferred ledgerjs libs to be flat in the /libs too, because then it's easy to just find the library. at the end of the day, a library is global (in the package.json / in the dep management) and it's also confusing for devs that @ledgerhq/hw-transport is actually under libs/ledgerjs/packages/hw-transport and not just libs/hw-transport, it would actually simplify all the dev ops config / custom things we did to make ledgerjs exception working

@gre gre marked this pull request as draft May 16, 2024 14:39
@sprohaszka-ledger
Copy link
Contributor

@gre, I find it hard to navigate and understand what part of the code base are meaningful together.

But I think this is another topic, not related to this PR

@gre
Copy link
Contributor Author

gre commented May 17, 2024

@sprohaszka-ledger i see. actually i see it could make sense to group libs per team ownership. would help on the codeowners too

@gre gre changed the title feat: integrate trustchain library implementation in monorepo feat: hw-trustchain library + trustchain library bootstrap May 17, 2024
@gre gre marked this pull request as ready for review May 17, 2024 15:43
@gre gre requested review from sprohaszka-ledger and a team May 17, 2024 15:59
@gre gre merged commit df528d1 into develop May 21, 2024
56 checks passed
@gre gre deleted the support/trustchain branch May 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants