Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live-12226): refactor WalletApi integration #6825

Merged

Conversation

liviuciulinaru
Copy link
Contributor

@liviuciulinaru liviuciulinaru commented May 9, 2024

  • send swap params as hash params
  • do not show the swap-live-app if pair or amount not selected

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@liviuciulinaru liviuciulinaru requested a review from a team as a code owner May 9, 2024 16:28
Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 9:24am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 9:24am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 9:24am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 9:24am
web-tools ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 9:24am

@liviuciulinaru liviuciulinaru marked this pull request as draft May 9, 2024 16:28
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label May 9, 2024
@liviuciulinaru liviuciulinaru force-pushed the fix/live-12226/refetch-quotes-on-pair-change branch 4 times, most recently from 312f689 to 0151c26 Compare May 15, 2024 12:07
@liviuciulinaru liviuciulinaru marked this pull request as ready for review May 15, 2024 14:13
@liviuciulinaru liviuciulinaru force-pushed the fix/live-12226/refetch-quotes-on-pair-change branch from c427477 to e99f4a4 Compare May 16, 2024 08:09
kallen-ledger
kallen-ledger previously approved these changes May 16, 2024
chore clean up

remove comments

chore: clean up

fix: move query  params to hash params

chore: add changeset

fix: add hashString to dev bar

rm memo

fix: type

fix: pr comments
@liviuciulinaru liviuciulinaru force-pushed the fix/live-12226/refetch-quotes-on-pair-change branch from 53367ce to 2639050 Compare May 21, 2024 09:23
@liviuciulinaru liviuciulinaru merged commit d9f97d3 into develop May 21, 2024
34 checks passed
@liviuciulinaru liviuciulinaru deleted the fix/live-12226/refetch-quotes-on-pair-change branch May 21, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants