-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/dsdk 276 create keyring-eth module #6792
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git βοΈ
4 Ignored Deployments
|
aussedatlo
changed the base branch from
develop
to
feat/dsdk-284-context-module-cal
April 30, 2024 16:00
live-github-bot
bot
added
the
ledgerjs
Has changes in the ledgerjs open source libs
label
Apr 30, 2024
aussedatlo
force-pushed
the
feat/dsdk-284-context-module-cal
branch
from
May 3, 2024 08:31
8261cc8
to
c23a6a8
Compare
aussedatlo
force-pushed
the
feat/dsdk-276-keyring-eth
branch
from
May 3, 2024 08:34
da34ca2
to
e78a60f
Compare
aussedatlo
force-pushed
the
feat/dsdk-284-context-module-cal
branch
from
May 3, 2024 08:54
c23a6a8
to
df2bf9a
Compare
aussedatlo
force-pushed
the
feat/dsdk-276-keyring-eth
branch
from
May 3, 2024 09:00
e78a60f
to
c663483
Compare
aussedatlo
force-pushed
the
feat/dsdk-284-context-module-cal
branch
from
May 7, 2024 07:37
df2bf9a
to
a06bb82
Compare
aussedatlo
force-pushed
the
feat/dsdk-284-context-module-cal
branch
10 times, most recently
from
May 16, 2024 10:32
cb53f9f
to
0bde643
Compare
aussedatlo
force-pushed
the
feat/dsdk-276-keyring-eth
branch
from
May 24, 2024 07:41
c663483
to
3c33d7c
Compare
aussedatlo
force-pushed
the
feat/dsdk-276-keyring-eth
branch
from
May 24, 2024 07:53
3c33d7c
to
fe883c6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
aussedatlo
force-pushed
the
feat/dsdk-276-keyring-eth
branch
from
May 27, 2024 07:46
fe883c6
to
b7fb0ef
Compare
aussedatlo
force-pushed
the
feat/dsdk-276-keyring-eth
branch
from
May 27, 2024 08:14
b7fb0ef
to
5cd6d31
Compare
lambertkevin
previously approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question, and it's more a (nice to have) feature request than anything π
aussedatlo
force-pushed
the
feat/dsdk-276-keyring-eth
branch
from
May 27, 2024 12:02
5cd6d31
to
9d18d1c
Compare
aussedatlo
force-pushed
the
feat/dsdk-276-keyring-eth
branch
from
May 27, 2024 12:09
9d18d1c
to
eedd616
Compare
ofreyssinet-ledger
previously approved these changes
May 27, 2024
aussedatlo
force-pushed
the
feat/dsdk-276-keyring-eth
branch
from
May 27, 2024 12:30
eedd616
to
8ad436f
Compare
lambertkevin
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Checklist
npx changeset
was attached.π Description
Create
keyring-eth
module to implement a simple keyring interface with:This PR handle two ticket:
β Context
π§ Checklist for the PR Reviewers