Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morpho Update for Ledger Plugin #248

Closed
wants to merge 6 commits into from

Conversation

0xPxt
Copy link
Contributor

@0xPxt 0xPxt commented Nov 19, 2024

No description provided.

@0xPxt 0xPxt requested a review from a team as a code owner November 19, 2024 13:25
fsamier
fsamier previously approved these changes Jan 14, 2025
@fsamier
Copy link
Contributor

fsamier commented Jan 15, 2025

@0xPxt thanks for your contribution and sorry for the delay.
This repository requires commits to be signed, please check Github documentation:
https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@0xPxt 0xPxt force-pushed the morpho-update branch 2 times, most recently from 2c6dad4 to c414d79 Compare January 20, 2025 07:45
@vforgeoux-ledger
Copy link
Member

@fsamier is it ready to be merged now?

@fsamier
Copy link
Contributor

fsamier commented Feb 26, 2025

Hi @0xPxt, you still need signed commits on this repository. Except that everything is good and we'll be able to merge this PR

@chcmedeiros
Copy link
Contributor

Hey @fsamier. It was easier for us to just created a new branch from the newest main, and pick out signed changes. Can we close this PR and use this one instead #259

@fsamier fsamier closed this Feb 26, 2025
auto-merge was automatically disabled February 26, 2025 12:47

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants