Update SELL info considering ExchangeSDK release #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stéphane Prohaszka <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| * `quoteId`: the id coming from your system and [forwarded to your LiveApp](./providers-liveapp) as a query parameter | ||
| * `accountId`: user's account id, [previously given to the LiveApp](./providers-liveapp) as a query parameter | ||
| * `amount`: amount that will be sell | ||
| * `feeStrategy`: `SLOW`, `MEDIUM`, `FAST` or `CUSTOM`. |
There was a problem hiding this comment.
how do you handle custom if no other param ?
we should re-discuss how to handle fees definition.
For swap with moonpay, the Custom is quite broken :/
There was a problem hiding this comment.
The fee is handle the same way it is handled by the swap (AFAIK). This is more on Ledger Live side :/
| // Crafting Payload... | ||
| return { | ||
| recipientAddress: "0xc0ffee254729296a45a3885639AC7E10F9d54979" | ||
| amount: BigInt("800000000000000000") |
There was a problem hiding this comment.
we should document when the amount is expected in smallestDenomination and when it's in natural unit.
There was a problem hiding this comment.
maybe better naming of the vars : amountInSmallestDenomination / amountInUsualUnit ?
Vin757
approved these changes
May 8, 2024
Signed-off-by: Stéphane Prohaszka <[email protected]>
pdesreux-ledger
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LIVE-9024