Update Edit.Circle.js

[poet-of-the-fall]

fixed circle edit bug

[ferily7]

Is this PR going to be merged in? It looks like it was approved -- I (and other people) am having issues with trying to edit the size of the circle and I think this should fix the bug..

[poet-of-the-fall]

Sorry, did not check on this one lately, but can’t merge as review is from a person with write access is missing. I switched to geoman-io lately…

[mdanko990]

could it be fixed soon? it still doesn't work

[AKopytenko]

Tell me, is there any progress on this task?
Since 2019, editing a circle on the map does not work. It is very strange.
Even stranger is that leaflet-draw-sector, which, if I’m not confusing anything, is based on Leaflet.circle, works without problems.

[vstoykov]

Actually the same fix plus one extra is present in #977

[DanielKucal]

As the PR doesn't seem to be merged soon, I'll share simple workaround for this problem. The solution is basically the same as for #1005:
TypeScript:

(window as any).radius = undefined;

JavaScript:

window.radius = undefined;

[AKopytenko]

MF! Can someone explain why this pull request is being rejected??

We overridden L.Edit.Circle, extended L.Edit.CircleMarker to include the radius definition and everything works. We have to do this in all our apps instead of just updating the Leaflet version in package.json...

Do these changes conflict with any other libraries??

[CodeWracker]

MF! Can someone explain why this pull request is being rejected??

We overridden L.Edit.Circle, extended L.Edit.CircleMarker to include the radius definition and everything works. We have to do this in all our apps instead of just updating the Leaflet version in package.json...

Do these changes conflict with any other libraries??

It hasn't actually been rejected. The repository owner simply abandoned maintaining it, and the author of the pull request ended up closing it due to the lack of response.

[AKopytenko]

It hasn't actually been rejected. The repository owner simply abandoned maintaining it, and the author of the pull request ended up closing it due to the lack of response.

As I understand it, this is ultimately a question for mourner, who is now working on Mapbox and who hasn't given a damn about Leaflet for a long time?))

[poet-of-the-fall]

Oh sorry, this was unintentional. But even after PR approval it was not possible to finally merge 😔 I was just cleaning my repositories a little bit, did not know that this closes the PR (now that it finally got an approved, after wall this time) 🤦‍♂️

[CodeWracker]

Oh sorry, this was unintentional. But even after PR approval it was not possible to finally merge 😔 I was just cleaning my repositories a little bit, did not know that this closes the PR (now that it finally got an approved, after wall this time) 🤦‍♂️

The approval must come from one of the repository admins. Any other approval just acts as a signal to them — it’s not considered a real approval by the repo itself. I’ve sent emails to the maintainers but never got a response.

At this point, I’ve kind of lost hope that they’ll ever look at this. The other issue linked in the comments above actually fixes this and a few other bugs too, but it’s facing the same problem: it’s just being ignored by the Leaflet admins.

[AKopytenko]

Oh sorry, this was unintentional. But even after PR approval it was not possible to finally merge 😔 I was just cleaning my repositories a little bit, did not know that this closes the PR (now that it finally got an approved, after wall this time) 🤦‍♂️

Let's cut/create a new one? Since the changes doesn't merge to master, let the pull-request at least be visible in the list of open.