Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for hollow tabs #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jsormaz
Copy link

@jsormaz jsormaz commented Aug 12, 2024

Add support for hollow tabs

-Adds a "Hollow Tab" Option
-Formally adds the "Tab label angle" input. This was partially implemented before but was not editable.
-Reworked the tab sketch generation to support these options.

image

image

image

This allows you to put a label on the outside of the bin as well that is visible when the bins are stacked.

@jsormaz
Copy link
Author

jsormaz commented Aug 12, 2024

Man, I'm pretty bad with git. I can't figure out how to remove my changes to "const.py" from this PR.

Those changes should be reverted, they are just my own defaults for my personal bin sizing.

@jensbodal
Copy link

Should be able to remove with:

git reset HEAD^ -- const.py
git commit --amend --no-edit

@jsormaz jsormaz force-pushed the master branch 2 times, most recently from f5ce927 to 620914b Compare August 13, 2024 13:44
@jsormaz jsormaz closed this Aug 13, 2024
@jsormaz jsormaz reopened this Aug 13, 2024
@jsormaz
Copy link
Author

jsormaz commented Aug 13, 2024

Should be able to remove with:

git reset HEAD^ -- const.py
git commit --amend --no-edit

Thanks a lot!
I couldn't get this to work, and I probably made a mess along the way but I got the result by resetting my fork to the upstream and then creating a new commit

I'm going to go read up on git now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants