Added getProperty and additional cli args #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lauszus
reviewed
May 6, 2024
Added getProperty support Added support for KBOOT property responses Added verbose log option Added option to not reset after upload Added option to assume upload success and not care the response times out
enochjlee
force-pushed
the
add-more-commands
branch
from
c9fb889
to
3cd577f
Compare
Lauszus
reviewed
May 7, 2024
| @@ -889,6 +924,11 @@ def cli() -> None: | |||
| type=int, | |||
| default=500000, | |||
| ) | |||
| optional.add_argument("--prop", help="The property tag to get", type=int, default=0) | |||
| optional.add_argument("--reset", help="Reset the target after upload", type=bool default=True) | |||
There was a problem hiding this comment.
Suggested change
| optional.add_argument("--reset", help="Reset the target after upload", type=bool default=True) | |
| optional.add_argument("--reset", help="Reset the target after upload", type=bool, default=True) |
| if parsed_args.verbose: | ||
| logger.setLevel(logging.DEBUG) | ||
| else: | ||
| logger.setLevel(logging.INFO) | ||
| logger.setLevel(logging.INFO) |
There was a problem hiding this comment.
Suggested change
| logger.setLevel(logging.INFO) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added getProperty support
Added support for KBOOT property responses
Added verbose log option
Added option to not reset after upload
Added option to assume upload success and not care the response times out
I don't have a device with the bootloader and a CAN interface, so I couldn't test that configuration. There may be unforeseen behavior conflicts.