Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Omega Realm #660

Merged
merged 9 commits into from
Sep 19, 2023
Merged

Add Omega Realm #660

merged 9 commits into from
Sep 19, 2023

Conversation

dnlblasco
Copy link
Contributor

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please remove / at the end of url (social.web)
  • Please remove / at the end of url (social.web_shop)
  • Please remove / at the end of url (social.web_support)

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

"social": {
"web": "https://omegarealm.net",
"web_shop": "https://omegarealm.net/store",
"web_support": "https://omegarealm.net/forum",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not support forum pages as support page - only faqs or contact forms.

},
"discord": {
"server_id": 1118625186867056731,
"rename_to_minecraft_name": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please set to false as true is only accepted for official partners atm.

Copy link
Member

@JakobBruening JakobBruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@JakobBruening JakobBruening merged commit 145f88e into LabyMod:master Sep 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants