Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RubyMC.net server mappings #1391

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Plunzi
Copy link
Contributor

@Plunzi Plunzi commented Oct 15, 2024

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

"web_shop":"https://shop.rubymc.de",
"discord":"https://discord.gg/Wu4PSKaQA2",
"youtube":"https://www.youtube.com/channel/UCdP40AdmG_ZMM6A19dJN8fw"
"web_shop":"https://shop.rubymc.net",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not reachable

"youtube":"https://www.youtube.com/channel/UCdP40AdmG_ZMM6A19dJN8fw"
"web_shop":"https://shop.rubymc.net",
"discord":"https://discord.gg/rubymc",
"youtube":"https://www.youtube.com/@rubymcnet"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not found

@Plunzi
Copy link
Contributor Author

Plunzi commented Oct 16, 2024

@DoJapHD The Web-Shop is currently undergoing some changes therefore it is not reachable, therefore the values entered are correct. Thanks for the review anyways.

@DoJapHD
Copy link
Collaborator

DoJapHD commented Oct 16, 2024

How long will that take?

@Plunzi
Copy link
Contributor Author

Plunzi commented Oct 18, 2024

Unsure, I'd guess it will take some more weeks.

@DoJapHD
Copy link
Collaborator

DoJapHD commented Oct 18, 2024

Then remove from PR, you can add again it if it's done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants