Update manifest.json for craftedhorizon #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Little fix for the IP, as we now use a subdomain
|
Just as an information: If your server is currently online, then our api returned a wrong status, we will have a look at it :) Reference: API URL (https://api.mcsrvstat.us/2/mc.craftedhorizon.net) |
|
The Server is online |
DoJapHD
requested changes
Oct 3, 2024
| "de" | ||
| "direct_ip": "mc.craftedhorizon.net", | ||
| "server_wildcards": [ | ||
| "%.craftedhorizon.net" |
There was a problem hiding this comment.
Not a real wildcard
https://i.imgur.com/U8hD4P3.png
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
- Invalid wildcard entry. Each entry must start with %.. Further information here: https://en.wikipedia.org/wiki/Wildcard_DNS_record (
server_wildcards)
Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.
|
wildcard is removed, as its not a real wildcard |
DoJapHD
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little fix for the IP, as we now use a subdomain
Type of change
Checklist
Further comments
Updated Manifest