Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Chopnex.net #1367

Merged
merged 3 commits into from
Sep 28, 2024
Merged

Added Chopnex.net #1367

merged 3 commits into from
Sep 28, 2024

Conversation

Henriiig
Copy link
Contributor

@Henriiig Henriiig commented Sep 28, 2024 •
edited
Loading

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

github-actions[bot]
github-actions bot previously requested changes Sep 28, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please remove / at the end of url (social.web)
  • Please remove / at the end of url (social.web_shop)
  • Please remove / at the end of url (social.discord)

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

DoJapHD
DoJapHD requested changes Sep 28, 2024
View reviewed changes
minecraft_servers/chopnex/background.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress image

minecraft_servers/chopnex/[email protected] Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress image

minecraft_servers/chopnex/manifest.json Outdated
"da"
],
"social": {
"web": "https://www.chopnex.net",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just links to shop so not needed

minecraft_servers/chopnex/manifest.json Outdated
"social": {
"web": "https://www.chopnex.net",
"web_shop": "https://butik.chopnex.net",
"discord": "https://discord.chopnex.net",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom links are reserved for partners
Use https://discord.gg/[INVITE]

minecraft_servers/chopnex/manifest.json Outdated
},
"discord": {
"server_id": 797595017891282995,
"rename_to_minecraft_name": true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true is reserved for partners
Change to false

@DoJapHD DoJapHD merged commit 6a60a00 into LabyMod:master Sep 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DoJapHD DoJapHD DoJapHD approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Henriiig @DoJapHD