Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added GalaxyMine.de #1353

Closed
wants to merge 15 commits into from
Closed

Added GalaxyMine.de #1353

wants to merge 15 commits into from

Conversation

TrismoTV
Copy link
Contributor

@TrismoTV TrismoTV commented Sep 21, 2024 •
edited
Loading

Type of change

  • [x ] Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • [ x] I have read the README doc
  • [ x] I have compressed the images appropriately (e.g. on https://tinypng.com)
  • [x ] I have created the manifest.json with the required values

Further comments

DoJapHD mein Server ist jetzt öffentlich!

github-actions[bot]
github-actions bot requested changes Sep 21, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

  • Please use your own page, not LABY.net (user_stats)

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Sep 21, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

  • Please use {userName} or {uuid} in your stats url (user_stats)

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

TrismoTV
TrismoTV commented Sep 21, 2024
View reviewed changes
Copy link
Contributor Author

@TrismoTV TrismoTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

github-actions[bot]
github-actions bot requested changes Sep 21, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

  • Please use {userName} or {uuid} in your stats url (user_stats)

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Sep 21, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Sep 21, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/galaxymine/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

github-actions[bot]
github-actions bot requested changes Sep 21, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/galaxymine/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

DoJapHD
DoJapHD requested changes Sep 22, 2024
View reviewed changes
minecraft_servers/galaxymine/manifest.json Outdated
"nice_name": "GALAXYMINE",
"direct_ip": "galaxymine.de",
"social": {
"web": "https://galaxymine.de",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a default Apache2 page

minecraft_servers/galaxymine/manifest.json Outdated
"direct_ip": "galaxymine.de",
"social": {
"web": "https://galaxymine.de",
"web_shop": "https://shop.galaxymine.de",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not reachable

@DoJapHD
Copy link
Collaborator

DoJapHD commented Sep 22, 2024

Server is in maintenance mode;
Reopen PR once server is publicly available

@DoJapHD DoJapHD closed this Sep 22, 2024
TrismoTV
TrismoTV commented Sep 22, 2024
View reviewed changes
Copy link
Contributor Author

@TrismoTV TrismoTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@TrismoTV TrismoTV changed the title Added GalaxyMine.de Added GalaxyMine.dee Sep 22, 2024
@TrismoTV TrismoTV changed the title Added GalaxyMine.dee Added GalaxyMine.de Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] requested changes

@DoJapHD DoJapHD DoJapHD requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrismoTV @DoJapHD