Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated manifest.json #1346

Merged
merged 10 commits into from
Sep 14, 2024
Merged

Updated manifest.json #1346

merged 10 commits into from
Sep 14, 2024

Conversation

octolexgaming
Copy link
Contributor

@octolexgaming octolexgaming commented Sep 14, 2024

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/citymine/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@@ -12,16 +12,19 @@
"citybuild": {
"name": "Citybuild",
"color": "#ADD8E6",
"command": "/spawn",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command should join the gamemode not just go to spawn...

"versions": "1.9<1.21"
},
"survival": {
"name": "Survival",
"color": "#FFA500",
"command": "/spawn",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command should join the gamemode not just go to spawn...

"versions": "1.9<1.21"
},
"grundstuecke": {
"name": "Grundstücke",
"color": "#66FE32",
"command": "/spawn",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command should join the gamemode not just go to spawn...

Copy link

Just as an information:
Your server join.citymine.eu could be offline.
In general, we only accept pull requests from servers, that are online. Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

If your server is currently online, then our api returned a wrong status, we will have a look at it :)

Reference: API URL (https://api.mcsrvstat.us/2/join.citymine.eu)

@octolexgaming
Copy link
Contributor Author

octolexgaming commented Sep 14, 2024

Just as an information: Your server join.citymine.eu could be offline. In general, we only accept pull requests from servers, that are online. Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

If your server is currently online, then our api returned a wrong status, we will have a look at it :)

Reference: API URL (https://api.mcsrvstat.us/2/join.citymine.eu)

Just a server restart. It should be available again and I adjusted the manifest so the commands join the specific modes.

@DoJapHD
Copy link
Collaborator

DoJapHD commented Sep 14, 2024

Server is offline?

@octolexgaming
Copy link
Contributor Author

Server is offline?

It was just a server restart.

@DoJapHD DoJapHD merged commit 39cd4b3 into LabyMod:master Sep 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants