Skip to content

Example UI test implementation #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

Example UI test implementation #13

wants to merge 8 commits into from

Conversation

lauriskr
Copy link
Contributor

This pull request gives a quick overview of changes needed to introduce UI/instrumentation testing capabilities.

Copy link
Contributor

@harri35 harri35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor suggestions. UI tests get stuck if the device has a password manager like BitWarden installed, but dealing with this is not part of the scope of the task so let's ignore it here.
Looks good to me. Can be merged.
Awesome work!

import mobi.lab.sample.app.common.test.Idler
import mobi.lab.sample.app.common.test.NoOpIdler
import javax.inject.Singleton

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just-in-case a comment here that this is the provider for UI test idler and this one provides the default no-op one and safe for production?

@@ -0,0 +1,46 @@
package mobi.lab.sample.app.common.test

interface Idler {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe one-lin comment on how to use the Idler? Eg:
"Create and set busy before the works starts, mark as done when the job is done."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants