-
Notifications
You must be signed in to change notification settings - Fork 0
Example UI test implementation #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
… TestSchedulerProvider
…tor-android into example/ui-tests
…into example/ui-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added minor suggestions. UI tests get stuck if the device has a password manager like BitWarden installed, but dealing with this is not part of the scope of the task so let's ignore it here.
Looks good to me. Can be merged.
Awesome work!
import mobi.lab.sample.app.common.test.Idler | ||
import mobi.lab.sample.app.common.test.NoOpIdler | ||
import javax.inject.Singleton | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just-in-case a comment here that this is the provider for UI test idler and this one provides the default no-op one and safe for production?
@@ -0,0 +1,46 @@ | |||
package mobi.lab.sample.app.common.test | |||
|
|||
interface Idler { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe one-lin comment on how to use the Idler? Eg:
"Create and set busy before the works starts, mark as done when the job is done."
…into example/ui-tests
This pull request gives a quick overview of changes needed to introduce UI/instrumentation testing capabilities.