Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand limits as needed in _prepare_for_brier #240

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

eacharles
Copy link
Collaborator

@eacharles eacharles commented Feb 5, 2025

Problem & Solution Description (including issue #)

#239

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@eacharles eacharles self-assigned this Feb 5, 2025
@eacharles eacharles force-pushed the issue/239/limits_in_brier branch from 2b29a8e to be34a53 Compare February 5, 2025 20:06
@eacharles eacharles requested review from jscora and mubdi February 5, 2025 20:07
Copy link

@jscora jscora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@eacharles eacharles merged commit ceb3610 into main Feb 6, 2025
4 checks passed
@eacharles eacharles deleted the issue/239/limits_in_brier branch February 6, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants