Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/178/metrics docs #181

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Issue/178/metrics docs #181

merged 6 commits into from
Aug 30, 2023

Conversation

aimalz
Copy link
Collaborator

@aimalz aimalz commented Jul 13, 2023

This addresses only the non-question aspects of #178.

@aimalz aimalz self-assigned this Jul 13, 2023
@aimalz aimalz requested a review from drewoldag July 13, 2023 17:55
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (35aeb0b) 100.00% compared to head (7ac5643) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #181   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines         2280      2280           
=========================================
  Hits          2280      2280           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qp/metrics/array_metrics.py 100.00% <ø> (ø)
src/qp/metrics/brier.py 100.00% <ø> (ø)
src/qp/metrics/metrics.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry I took so long to review this, it fell off my radar. This looks good. You can really tell I didn't know what I was docstring'ing when I put this together initially :)

@aimalz aimalz merged commit 38a06f7 into main Aug 30, 2023
@aimalz aimalz deleted the issue/178/metrics-docs branch August 30, 2023 20:09
@aimalz aimalz restored the issue/178/metrics-docs branch August 30, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants