Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scipy deprecation in halos/profiles/ia.py #1188

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Scipy deprecation in halos/profiles/ia.py #1188

merged 2 commits into from
Jun 26, 2024

Conversation

hsinfan1996
Copy link
Contributor

@hsinfan1996 hsinfan1996 commented Jun 26, 2024 •
edited
Loading

change x to a kwarg.

@hsinfan1996
Copy link
Contributor Author

Somewhat related to PR #1187.

@hsinfan1996
Copy link
Contributor Author

isitgr 1.0.3 does not work and I cannot find what part of the code has changed. It is still not compatible with Numpy 1.24 and above.

@hsinfan1996 hsinfan1996 marked this pull request as ready for review June 26, 2024 09:14
@hsinfan1996 hsinfan1996 requested a review from damonge June 26, 2024 09:14
@coveralls
Copy link

coveralls commented Jun 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9676741060

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.459%
Totals Coverage Status
Change from base Build 9566319765: 0.0%
Covered Lines: 6558
Relevant Lines: 6729
💛 - Coveralls

damonge
damonge approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@hsinfan1996 hsinfan1996 merged commit 132cfc1 into master Jun 26, 2024
4 checks passed
@hsinfan1996 hsinfan1996 deleted the scipy_deprecation branch June 26, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damonge damonge damonge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsinfan1996 @coveralls @damonge