Use length-bounded string/memory functions #7709
Open
+88
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces all calls to sprintf() in first-party code with calls to snprintf() or some other reasonable alternative.
Remove bitmask, since the format specifier already restricts the output to 2 characters per byte
I used a different name in my test code to make sure my method was working properly and forgot to change the name back. Fixed!
|
I'd be reluctant to change anything in |
sakertooth
approved these changes
Mar 7, 2025
rubiefawn
changed the title
len could be < size
This is done by a) explicitly initializing buffers to 0, and b) providing snprintf() with one less than the buffer size, so that the last remaining element will always retain its initial value (which is 0)
sakertooth
reviewed
Mar 8, 2025
tresf
reviewed
Mar 12, 2025
tresf
reviewed
Mar 12, 2025
tresf
reviewed
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3949 by replacing all calls to
sprintf()andstrcpy()in first-party code (read: not in a git submodule orsrc/3rdparty) with calls tosnprintf()or some other reasonable alternative, depending on context.This does not resolve the memory management issue raised in this comment.