Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in some variorum JSON examples. #569

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

tpatki
Copy link
Member

@tpatki tpatki commented Jul 30, 2024

Description

Fixes memory leak in some variorum JSON examples as detected by -fsanitize=address.
Fixes #567 .

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/architecture support (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Build/CI update

How Has This Been Tested?

Tested on Lassen by adding -fsanitize=address in the CMakeLists.txt file in src/examples (the Variorum build to use address sanitizer checks will be updated as a separate PR.)

Checklist:

  • I have run ./scripts/check-code-format.sh and confirm my code code follows the style guidelines of variorum
  • I have added comments in my code
  • My changes generate no new warnings (build with -DENABLE_WARNINGS=ON)
  • New and existing unit tests pass with my changes

Thank you for taking the time to contribute to Variorum!

@tpatki tpatki self-assigned this Jul 30, 2024
@tpatki tpatki added this to the Minor Update: v0.8.1 milestone Jul 30, 2024
@tpatki tpatki merged commit 28d7ef5 into LLNL:dev Jul 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some JSON examples leak memory
1 participant