WIP: Refactor serac to support RAJA #987
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables CUDA execution via RAJA, as well as compilation of GPU kernels with NVCC. Several important restrictions imposed by nvcc that this PR works around are
(1) Multiple variadic template parameters in the enclosing function of a generic lambda
(2) Using [=] to capture local variables in a lambda declaration doesn't work with if the enclosing function has a variadic template parameter
(3) Fully generic lambdas (where both arguments and return type are deduced with
auto
)Some template programming workarounds were required to expand the multiple template parameter restriction of nvcc, but this is currently passing some very basic unit tests ported from CPU.