Albedo pumping bugfix #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the .v file to the Package file.
for Basis build.
Addresses bug that affects albedo-like pumping at the plates - The pumped fraction is Gamma_pump = (1-alb)*(n*v^bar)/4)*A - Previously, A was taken as sx, the area of the cell normal to the poloidal direction (i.e. flux tube cross-section) - However, for shaped, non-orthogonal target plates, the projection results in a larger pumping area than the perpendicular, increasing pumping - This projection is now taken into account when isoldalbarea = 0 - By default, isoldalbarea = 1, and can be varied continuously Co-Authored-By: Thomas Rognlien <[email protected]>
tdrognlien
approved these changes
Jan 6, 2024
There was a problem hiding this comment.
I believe the changes made in defining and using the new poloidal-cell plate area areapl for albedo pumping of gas is correct. This area can be smoothly varied from the old incorrect value of com.sx to the correct value of com.sxnp by varying bbb.isoldalbarea from 1 to 0.
|
Changes checked manually by TDR, OK to override GitHub review process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses bug that affects albedo-like pumping at the plates
Also fixes issues for Basis builds by meyer8.
Co-Authored-By: Thomas Rognlien [email protected]