-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(benches): add two new binaries to benchmark scaling #269
Open
imrn99
wants to merge
27
commits into
master
Choose a base branch
from
add-edge-size-bench
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need to rezrite split_edge_noalloc to be a transactional routine
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
==========================================
- Coverage 84.94% 84.85% -0.10%
==========================================
Files 62 62
Lines 9407 9417 +10
==========================================
Hits 7991 7991
- Misses 1416 1426 +10 ☔ View full report in Codecov by Sentry. |
these will be generalized to cell insertion anyway
now there are issues due to asserts in core operations; since the assertions operate in-transaction, some forward passed values can mess up the checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scope: benches
Type of change: feat
Content description:
grid-random-split
binary. it generates a fixed size unit grid with each square cell having a diagonal split, the direction being random. the map is saved as a legacy VTK binary filecut-edges
binary. it loads a a map from a VTK file, and divide its cells iteratively until a target edge size is reached. the input mesh is assumed to be a triangle mesh, we guarantee that each intermediate step and final result are as wellis_unused
andis_unused_transac
to basic map operations