Update readme with usage of UseTaskWhenAll#23
Merged
KuraiAndras merged 5 commits intoKuraiAndras:masterfrom Jun 16, 2025
Merged
Update readme with usage of UseTaskWhenAll#23KuraiAndras merged 5 commits intoKuraiAndras:masterfrom
UseTaskWhenAll#23KuraiAndras merged 5 commits intoKuraiAndras:masterfrom
Conversation
KuraiAndras
requested changes
Jun 16, 2025
Owner
KuraiAndras
left a comment
KuraiAndras
left a comment
There was a problem hiding this comment.
Please also append the changelog, with a new section for 7.0.1
KuraiAndras
requested changes
Jun 16, 2025
Comment on lines
156
to
160
| You can create a weak subscription by using the `SubscribeWeak` method. This subscription uses a `WeakReference` which will let the subscriber to be garbage collected without the need to unsubscribe (although you still can unsubscribe manually). Subscribing methods on `MonoBehavior` instances in Unity3D might result in unexpected behavior, so you should be careful with it. | ||
|
|
||
| ```c# | ||
| courier.SubscribeWeak<MyNotification>(notification => /*...*/); | ||
|
|
||
| courier.SubscribeWeak<MyNotification>((notification, cancellation) => /*...*/); | ||
| ``` | ||
|
|
||
| ### Capturing thread context |
Contributor
Author
There was a problem hiding this comment.
oops mistake... will undo
Contributor
Author
The whole "UseTaskWhenAll" feature goes into 7.0.1? |
Owner
No, I have already published 7.0.0. Just the changes in this pr |
KuraiAndras
approved these changes
Jun 16, 2025
fretje
changed the title
UseTaskWhenAllUseTaskWhenAll
Owner
|
Everything seems okay, can we merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a couple more commits left on the parallel branch... you were a bit too fast with merging...
Anyways, here they are.
Thanks for all the swift actions btw!