Use Invoke iso DynamicInvoke#18
Conversation
CHANGELOG.md
Outdated
| @@ -1,3 +1,6 @@ | |||
| # vNext | |||
There was a problem hiding this comment.
Ok, done!
Off topic: any reason you're pinning the sdk? Can I add a "rollForward": "latestMajor"? (I do now locally, to be able to build and test as I don't have sdk 8 installed...)
There was a problem hiding this comment.
I usually pin the SDK for reproducible builds, but since in CI the dotnet install script should install the one specified in the global.json anyway, I can add it back
There was a problem hiding this comment.
Also I am adding a new CI, which does not require sonar. It seems like that in the last few years github changed the workflow system, so that forks can't access secrets 🫤
There was a problem hiding this comment.
So, hopefully now everything should work for PRs. Can you update this one too so the new ci is run?
Also, sorry for the problems around prs-I have not touched this repo in two years, and it seems I did not really make it future proof
2 participants
The change was actually much less elaborate than I first anticipated...
This should do it... at least all the tests still run ;-)
I also found a bug while scanning the code, but fixed that in a separate pr (#19)