Fix async refresh #342
Merged
Fix async refresh #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 32 32
Lines 1082 1099 +17
Branches 180 185 +5
=======================================
+ Hits 1080 1097 +17
Partials 2 2
Continue to review full report at Codecov.
|
nrbnlulu
reviewed
Jul 26, 2022
| @@ -39,5 +39,13 @@ class Mutation: | |||
| delete_cookie = jwt_mutations.DeleteJSONWebTokenCookie.delete_cookie | |||
|
|
|||
|
|
|||
| schema = Schema(query=Query, mutation=Mutation, extensions=[AsyncJSONWebTokenMiddleware]) | |||
| @strawberry.type | |||
There was a problem hiding this comment.
Is that required (RefreshAsync) or just for readability?
There was a problem hiding this comment.
RefreshAsync will be required, the refresh token db access is done inside the resolver so it must be wrapped in sync_to_async. Obtain handles this in decorators where it is already async safe.
There was a problem hiding this comment.
Other are just for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async refresh was currently somehow broken. This fixes it and adds explicit async resolvers for clarity.
#337