Skip to content

Reconcile dependencies with colab and add dockerfile #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bergsalex
Copy link
Contributor

@bergsalex bergsalex commented Jul 10, 2025

This PR more specifically defines project dependencies in the pyproject.toml so as to be better aligned with the Google Colab docker image.

It also adds a dockerfile which can build and install the package on top of the Google Colab docker image.

@bergsalex bergsalex self-assigned this Jul 10, 2025
@bergsalex bergsalex added enhancement New feature or request repository refactor Related to package structure refactor project labels Jul 10, 2025
Copy link
Contributor

@SkepticRaven SkepticRaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to place the Dockerfile inside the vm folder?
Changing this we'd also need to be careful about how local files are pathed (e.g. pip commands that point to local files).

@bergsalex
Copy link
Contributor Author

Do we want to place the Dockerfile inside the vm folder? Changing this we'd also need to be careful about how local files are pathed (e.g. pip commands that point to local files).

I thought about it and decided to place it at root. This makes the definition (local file paths) more intuitive, and makes it easy to build the container since the docker command assumes the file is at the root of the build context.

e.g.

docker build . 

Instead of

docker build -f vm/Dockerfile .

or

cd vm
docker build -f Dockerfile ..

Happy to switch it back if you'd prefer to keep the image definitions consistently in vm.

@bergsalex bergsalex merged commit 20db522 into repository-reorganization Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request repository refactor Related to package structure refactor project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants