Improve efficiency of Tracklet Generation #48
Conversation
… unit and benchmark tests
bergsalex
requested review from
keithshep,
gbeane,
SkepticRaven,
dahhei,
C-1337ka and
pavan-el
| ) | ||
|
|
||
| # Apply priority adjustment if enabled | ||
| if match_cost is not None and prioritize_long: |
There was a problem hiding this comment.
I'm finding the formatting of this block a bit hard to follow
There was a problem hiding this comment.
The crazy Github tab size really isn't helping. Does anyone mind if I ruff format the whole file to replace the tabs with spaces?
There was a problem hiding this comment.
https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-user-account-settings/managing-your-tab-size-rendering-preference
Default is 8. I'd prefer having the formatting stuff not mask the changes just yet (but should definitely happen in the near future!)
There was a problem hiding this comment.
Ran updated version on some test data and doesn't appear to change output.
Unfortunately doesn't appear to address #14 yet.
Rewriting VideoObservations.stitch_greedy_tracklets method and adding unit and benchmark tests.
Note that I did not apply ruff formatting or linting to the entire
src/mouse_tracking/utils/matching.pyfile as I wanted the changes tostitch_greedy_trackletsto be as obvious as possible.