Rescue async voice listening from mystery meat packets #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchristgit
reviewed
Aug 16, 2024
lib/nostrum/voice/session.ex
Outdated
Comment on lines
157
to
161
| rescue | ||
| _error -> | ||
| Logger.warning( | ||
| "Received bad voice packet in guild_id #{state.guild_id}: #{inspect(packet)}" | ||
| ) |
There was a problem hiding this comment.
Should we still log the warning? I feel like this being a blanket rescue with no source of the error makes it hard to find out where it came from.
There was a problem hiding this comment.
Log the exception is what I meant.
There was a problem hiding this comment.
Sure, it will most likely be the same function clause error during the decrypt, but doesn't hurt. Someone's only seen this occur once.
jchristgit
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we've had one case of a non-RTCP/non-RTP packet (at least not one that was properly encrypted) being received on the open UDP port, and this causes the
Voice.Sessionto crash. I haven't encountered this in testing but this will protect against these edge cases occurring in the wild.