Add documentation and tests for DataColumnArithmetics.kt#1769
Open
Add documentation and tests for DataColumnArithmetics.kt#1769
DataColumnArithmetics.kt#1769Conversation
Allex-Nik
commented
Mar 26, 2026
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/DataColumnArithmetics.kt
Show resolved
Hide resolved
Allex-Nik
commented
Mar 26, 2026
core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/DataColumnArithmetics.kt
Show resolved
Hide resolved
Allex-Nik
commented
Mar 26, 2026
core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/DataColumnArithmetics.kt
Show resolved
Hide resolved
Allex-Nik
commented
Mar 26, 2026
Allex-Nik
commented
Mar 26, 2026
Allex-Nik
commented
Mar 26, 2026
Allex-Nik
commented
Mar 26, 2026
Allex-Nik
commented
Mar 26, 2026
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/DataColumnArithmetics.kt
Show resolved
Hide resolved
Allex-Nik
added
documentation
Allex-Nik
commented
Mar 26, 2026
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/DataColumnArithmetics.kt
Show resolved
Hide resolved
Jolanrensen
requested changes
Mar 27, 2026
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/DataColumnArithmetics.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/DataColumnArithmetics.kt
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/DataColumnArithmetics.kt
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/DataColumnArithmetics.kt
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/DataColumnArithmetics.kt
Show resolved
Hide resolved
Allex-Nik
force-pushed
the
data-column-arithmetics-docs-tests
branch
from
e6cf6f1 to
3ed1f51
Compare
Jolanrensen
approved these changes
Mar 30, 2026
koperagen
reviewed
Mar 31, 2026
|
|
||
| In most transformations, these column operations are usually not the preferred approach in Kotlin DataFrame, | ||
| because the library provides row-based APIs such as [`add`](add.md), [`update`](update.md), [`map`](map.md), and `expr`, | ||
| which are usually recommended. |
Collaborator
There was a problem hiding this comment.
Please elaborate on expr { } as a column selector => row expression adapter
for example,
df.groupBy { city + "mySuffix" } is equivalent to
df.groupBy { expr { city + "mySuffix" } }, but in expr city is seen as single String value, not as column
Collaborator
Author
There was a problem hiding this comment.
Done :)
Please see if it is correct now. I tried to explain the expr usage and included similar examples. I also specified the name of the column for expr (so that the results for both versions look the same), otherwise the column was called "untitled" for the version with expr, whereas in the version without expr the column had a specific name. Is that fine?
zaleslaw
approved these changes
Mar 31, 2026
AndreiKingsley
approved these changes
Mar 31, 2026
Collaborator
AndreiKingsley
left a comment
AndreiKingsley
left a comment
There was a problem hiding this comment.
Great KoDEx usage!
Allex-Nik
force-pushed
the
data-column-arithmetics-docs-tests
branch
from
3ed1f51 to
4d60e09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #530
Added:
for
DataColumnArithmetics.kt