Skip to content
This repository has been archived by the owner on Jul 13, 2020. It is now read-only.

migrate anko commons(include v4, v7) to androidx #735

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

phxnirvana
Copy link

No description provided.

build.gradle Outdated
ext.androidx_legacy_version = '1.0.0'
ext.androidx_appcompat_version = "1.0.2"
ext.androidx_annotation_version = '1.0.2'
ext.androidx_constrainlayout_version = "1.1.3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: androidx_constraintlayout_version - but also, for my own edification, are these actually used anywhere? I don't see them referenced anywhere else but I may be missing something...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow, I forget to change the constraint-layout module...
already added now

@mo3in
Copy link

mo3in commented Apr 24, 2019

what happen now? @4u7 @yanex

@4u7 4u7 self-assigned this May 13, 2019
@guger
Copy link

guger commented Sep 8, 2019

I'd really appreciate seeing this pull request merged and released!

@jlberrocal
Copy link

seems like Anko project is dead, IntelliJ have no interest in this open source project

@BejanAlina
Copy link

@jlberrocal is this official ? Would be nice if at least this pull request is merged, if not deployed to another repo

@jlberrocal
Copy link

is not official, but if you take a look to the last change date you can infer so.

@Makentoshe
Copy link

If you want to update anko to androidx, you must also update generator. Regenerate all apis and update tests.

@phxnirvana
Copy link
Author

I think anko is already deprecated, since google has produced android-ktx.
I tried to update all, but generator cannot generate some of the interface.
And I don't have enough time to study and modify the generator for now, should I just close this pr?

@Makentoshe
Copy link

As a know, the maintainers has no time for it - they all are littered with work and other projects. I'm trying to do something with generator, but it has some underwater rocks. This pr may be usefull in a future

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants