Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 156, avoid PHP 7.4 Notice (array offset on value of type int) #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ennorehling
Copy link

This should fix issue #156 - $port is an integer, and there is no reason to access it as an array or string.

I noticed there is no test for this, and don't know how to create one. Also, the UnirestRequestTest::testGzip test seems to be failing, but it already did that before my change.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants