-
Notifications
You must be signed in to change notification settings - Fork 22
feat(tls): add SANs support for both DNS-names and URIs #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds two new Lua functions (and the corresponding C logic) to configure custom SANs validation in nginx: * `resty.kong.tls.set_upstream_ssl_sans_dnsnames()` * `resty.kong.tls.set_upstream_ssl_sans_uris()` Part of KAG-6247.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucab, very good. I approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Is this testable? Should we have something in t/
?
I think this is not testable in isolation (at least not in a meaningful way), as it works in tandem with the related nginx patch wrt. TLS-name validation logic. |
This adds two new Lua functions (and the corresponding C logic) to configure custom SANs validation in nginx:
resty.kong.tls.set_upstream_ssl_sans_dnsnames()
resty.kong.tls.set_upstream_ssl_sans_uris()
Part of KAG-6247.
Notes: