chore: add v2alpha1 group and add ControlPlane type #441
+1,521
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
ko-controlplane-crd
branch
3 times, most recently
from
a60ec58 to
179dde6
Compare
pmalek
force-pushed
the
ko-controlplane-crd
branch
from
179dde6 to
72293bb
Compare
pmalek
commented
Jun 2, 2025
| @@ -31,6 +31,7 @@ func init() { | |||
| // ControlPlane is the Schema for the controlplanes API | |||
| // | |||
| // +genclient | |||
| // +kubebuilder:storageversion | |||
There was a problem hiding this comment.
The storage version will move to v2alpha1 when we progress with it and get closer to the release.
Co-authored-by: Jakub Warczarek <[email protected]>
|
Letting @mlavacca chip in on the review and thus leaving this unmerged for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a
ControlPlaneversion:v2alpha1which contains the following breaking changes with respect tov1beta1:deploymentfielddataplanefield from*stringto a typed union field which can be set to either a url (of Admin API) or a name ofDataPlaneresource (the same use case as with olddataplanefield)featureGates,controllersandadminAPIfields. The first 2 have string based arrays instead of strongly types fields (most likely the direction we'll move forward with but can potentially be changed based on feedback).CRD validation tests have not been added (yet) to allow feedback which could influence the design.
Which issue this PR fixes
Part of Kong/gateway-operator#1358
Special notes for your reviewer:
Further changes to the new
v2alpha1API (like new, individual fields) will be added when this PR gets reviewed so that throw away work is avoided.PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes