chore(clustering): cleanup redundant checkers #13017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some logic in checkers is made redundant by the fact the same fields exist in removed_fields, so it would never be reached. This commit removes the redundant logic
github-actions
bot
added
core/clustering
cherry-pick kong-ee
nowNick
approved these changes
May 21, 2024
|
@samugi I don't see |
Oh, got it: |
bungle
removed
the
cherry-pick kong-ee
|
Removing cherry-pick label as already cherry-picked. |
bungle
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
some logic in checkers is made redundant by the fact the same fields exist in removed_fields. This commit removes the redundant logic
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4457