Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Lint): Use oxlint for linting #8534

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented Mar 27, 2025

Motivation:
Our current eslint configuration is quite complex which makes it hard to update to the latest version and keep up to date.
There are also times where formatting rules fight each other and saving a file leads to a flash of formatting that creates some very weird indentation results.
Ideally we want our linter to only be concerned about code issues and use a formatter like prettier to handle how our code is formatted.
oxlint is now in beta and already used by some pretty big projects

Highlights:

  • Replaces eslint with oxlint
  • Added settings and recommended extension for oxlint
  • Fixed some issues where we have unused variables and no keys on react lists
  • Lint in GitHub actions goes from ~15s to ~0s

Figure out:

  • What rules should we enforce per workspace?
  • Review and compare overall DX compared to eslint

@gatzjames gatzjames requested a review from a team March 27, 2025 11:13
@gatzjames gatzjames self-assigned this Mar 27, 2025
@gatzjames gatzjames mentioned this pull request Mar 27, 2025
7 tasks
@CurryYangxx
Copy link
Member

What is our motivation for replacing eslint with oxlint?
oxlint doesn't seem to have a major release yet, and I'm worried that it's not stable enough for us.
I suggest waiting until it releases a major version and is verified by more people before deciding whether to use it.

@jackkav
Copy link
Contributor

jackkav commented Mar 31, 2025

I agree with @CurryYangxx, especially as they are still working on an unreleased formatter. Keep the branch around though and we can revisit on their 1.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants