Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix importing creates duplicate resources #7081

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

huuphat1908
Copy link

@huuphat1908 huuphat1908 commented Feb 10, 2024

Current logic

  • Always generate new id for resources when importing
  • No check for existing resources

New logic

  • Only generate new id for resources when importing if the resource has no id
  • Add logic to check if resources have already existed

Test data

Test evidence

Related issue: #5946

@CLAassistant
Copy link

CLAassistant commented Feb 10, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants