feat: add customizable shortcut for toggling comment in editor #6889
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
iamkhav
force-pushed
the
keybind-for-toggleComment
branch
from
f7009b8
to
0dda1a1
Compare
|
Hi @jackkav @gatzjames @filfreire, Would you be able to give me an opinion on this? I'm not a skilled TS person so I'm hoping for some hints on how this could be improved and whether tests are necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hey everyone,
This PR allows customizing the shortcut for toggling comments.
I personally couldn't use the default shortcut since I'm using a MacOS with DE keyboard layout. More detail in the linked threads.
Related to feature request #4112
Related to issue #2018