Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: the folder deletion #6527

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

kobenguyent
Copy link
Contributor

resolves #6487

  • bring back delete confirmation
  • move delete outside for faster access
Screen.Recording.2023-09-18.at.15.00.46.mov

@ankoyeeri
Copy link

ankoyeeri commented Sep 26, 2023

Hi @kobenguyent, I'm from #6487 too.
I have a small proposal, if it wouldn't be a big headache for you: add a pop-up window instead of a confirmation button, that appears at the same place where deletetion-button is. You saved user from a single misclick, but haven't saved them from double-click 😅

@kobenguyent
Copy link
Contributor Author

hey @ankoyeeri thanks for your input, per checked with @gatzjames.

This one we want to standardise all over the app so we might go with a Confirmation dialog for now since we don't have an accessible confirm button in menus

@sunny-chung
Copy link

How about only counting as "confirmation" if the time difference between two clicks are greater than an interval, say 0.5 seconds? This saves users from an unintended double-click. An animation can be added to make the behaviour doesn't look weird.

Hello.HTTP.prevents.misclicking.delete.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add warning on delete folder
3 participants