Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #5942: Retain exported ID for resource #6521

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

adammkelly
Copy link

Closes #5942

If an imported config has references to requests via the response plugin they are dereferenced as the imported config gets all new ids.

If this has downstream consequences, please let me know.

changelog(Fixes): Added a fix to retain the id from imported resources

@wingedrhino
Copy link

It would be nice if this MR is prioritized! Export of request chains has been pretty broken for a while now.

@dukesteen
Copy link

When is this being released? seems like a simple fix to me

@pjloomis
Copy link

My team is experiencing the same problem. If you export a document, then import later, existing requests are assigned new request IDs. Every Tag, Request Chaining, basically everywhere you've made a reference to a request's ID is now broken.

Steps to reproduce:

  1. Create a new design document
  2. Add a Get request. Here's a public api - https://datausa.io/api/data?drilldowns=Nation&measures=Population
  3. Open settings for the Request and save the request id (req_00534c74137948da90521431b379b27b)
  4. Export the design document
  5. Delete the design document
  6. Import the design document
  7. Open and go to the request
  8. Open settings for the request and note that the request ID has changed (req_2d5680a437594dc6986d75f9dfda6988)

This occurs for Insomnia 8.4.0 on both PC and Mac

@jnazaren
Copy link

Bump - any updates on when this might be released?

@dukesteen
Copy link

Bump - any updates on when this might be released?

I just switched to postman again..

@jnazaren
Copy link

jnazaren commented Dec 7, 2023

@gatzjames @filfreire

@PedroLuisBrilhadori
Copy link

By debugging a little, you can see that each request has a unique and global id. Wouldn't it be better for each request to be unique in its document?

With these corrections, it is possible to import requests with their ID'S, however. If you already have these ID'S in your insomina it returns an error.

I'm trying to research more about requests and documents within the code.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kap199297
Copy link

Is there any update on this PR? When it is going to be available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version 2023.2 Imports of request collection no longer work