Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve import UX #5869

Merged
merged 26 commits into from
Mar 31, 2023
Merged

Improve import UX #5869

merged 26 commits into from
Mar 31, 2023

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented Mar 29, 2023

changelog(Improvements): Improved the way imports are handled to avoid issues similar to #4274 where sometimes users would import a file, see a success message but data would not be properly imported

Highlights:

  • Revamped UX for importing. Display what is about to be imported and where and allow to edit the import location.
  • Moved import logic in routes
  • Importing is done in 2 phases:
    • Scan: parse resources from the input and map them to Insomnia models
    • Import: the parsed resources to the location (project/workspace) provided by the user

TODO:

  • Clean up UI styles
  • [ ] Add supported import icons to the Settings/Data tab
  • Simplify importResources logic in common/import
  • Error handling

Future work:

  • Since we don't rely on the order of imports anymore because of the scan phase we can turn the import process into a stream to handle large resources. This would also enable cancelation in the middle of an import and allow us to rollback any updates to the db.
  • Handle multi-workspace imports and importing from commands

Closes INS-2439
(Potentially) Closes #4274, #4246, #2771, #4283, #5558

@gatzjames gatzjames self-assigned this Mar 29, 2023
@gatzjames gatzjames requested a review from a team March 29, 2023 11:14
@filfreire filfreire added this pull request to the merge queue Mar 31, 2023
@filfreire filfreire removed this pull request from the merge queue due to a manual request Mar 31, 2023
@filfreire filfreire added this pull request to the merge queue Mar 31, 2023
Merged via the queue into Kong:develop with commit 29acc92 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Import suceeded" but nothing changes
3 participants