Skip to content

Commit

Permalink
chore: only generate tar.gz for aarch64 linux for now
Browse files Browse the repository at this point in the history
  • Loading branch information
hexchain committed Jan 28, 2025
1 parent 5a4be9f commit 5500d14
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 15 deletions.
15 changes: 9 additions & 6 deletions .github/workflows/release-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,17 @@ jobs:
run: |
echo "INSO_VERSION=$(jq .version ./packages/${{ env.INSO_PACKAGE_NAME }}/package.json -rj)" >> $GITHUB_ENV
- name: Install snapcraft (Linux arm64 only)
if: runner.os == 'Linux' && runner.arch == 'arm64'
# TODO: fix snapcraft generation on aarch64
- name: Package app (ARM64 Linux only)
if: runner.os == 'Linux' && runner.arch == 'ARM64'
shell: bash
run: sudo snap install snapcraft --classic
run: npm run app-package
env:
NODE_OPTIONS: '--max_old_space_size=6144'
BUILD_TARGETS: tar.gz

- name: Package app (Linux only)
if: runner.os == 'Linux'
- name: Package app (X64 Linux only)
if: runner.os == 'Linux' && runner.arch == 'X64'
shell: bash
run: npm run app-package
env:
Expand Down Expand Up @@ -146,7 +150,6 @@ jobs:
CREDENTIAL_ID: ${{secrets.ES_CREDENTIAL_ID}}
TOTP_SECRET: ${{secrets.ES_TOTP_SECRET}}


- name: Package inso
run: |
echo "Replacing electron binary with node binary"
Expand Down
10 changes: 1 addition & 9 deletions .github/workflows/release-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ jobs:
sentry-cli sourcemaps upload -r ${{ env.RELEASE_VERSION }} ./artifacts/*-latest-sentry
# TODO: also release snap for aarch64 Linux
- name: Upload x64 Linux snap to snapcraft (beta and stable only)
if: ${{ !contains(github.event.inputs.version, 'alpha') }}
uses: canonical/action-publish@v1
Expand All @@ -227,15 +228,6 @@ jobs:
snap: artifacts/Linux-X64-artifacts/insomnia/dist/Insomnia.Core-${{ env.RELEASE_VERSION }}-x64.snap
release: ${{ contains(github.event.inputs.version, 'beta') && 'beta' || 'stable' }}

- name: Upload arm64 Linux to snapcraft (beta and stable only)
if: ${{ !contains(github.event.inputs.version, 'alpha') }}
uses: canonical/action-publish@v1
env:
SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.SNAPCRAFT_LOGIN_FILE_NEW }}
with:
snap: artifacts/Linux-ARM64-artifacts/insomnia/dist/Insomnia.Core-${{ env.RELEASE_VERSION }}-arm64.snap
release: ${{ contains(github.event.inputs.version, 'beta') && 'beta' || 'stable' }}

# TODO: also release for aarch64 Linux?
- name: Upload .deb to pulp and/or cloudsmith (stable only)
if: ${{ !contains(github.event.inputs.version, 'alpha') && !contains(github.event.inputs.version, 'beta') }}
Expand Down

0 comments on commit 5500d14

Please sign in to comment.