-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ownership): change Kong permissions to be kong:root #632
Open
Tieske
wants to merge
1
commit into
master
Choose a base branch
from
perm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| function run_test { | ||
| # the suite name below will only be used when running this file directly, when | ||
| # running through "test.sh" it must be provided using the "--suite" option. | ||
| tinitialize "Docker-Kong test suite" "${BASH_SOURCE[0]}" | ||
|
|
||
| tchapter "ownership is root:kong" | ||
|
|
||
|
|
||
| for filename in \ | ||
| /usr/local/share/lua/5.1/ \ | ||
| /usr/local/share/lua/5.1/kong/plugins/ \ | ||
| /usr/local/lib/lua/5.1/ \ | ||
| /usr/local/lib/luarocks/rocks-5.1/ | ||
| do | ||
| ttest "owenership $filename" | ||
| local USR | ||
| local GRP | ||
| USR=$(docker run -ti --rm "kong-$BASE" ls -ld $filename | awk '{print $3}') | ||
| GRP=$(docker run -ti --rm "kong-$BASE" ls -ld $filename | awk '{print $4}') | ||
| if [ "$USR:$GRP" == "root:kong" ]; then | ||
| tsuccess | ||
| else | ||
| tmessage "user and group found to be $USR:$GRP" | ||
| tfailure | ||
| fi | ||
| done | ||
|
|
||
| tfinish | ||
| } | ||
|
|
||
| # No need to modify anything below this comment | ||
|
|
||
| # shellcheck disable=SC1090 # do not follow source | ||
| [[ "$T_PROJECT_NAME" == "" ]] && set -e && if [[ -f "${1:-$(dirname "$(realpath "$0")")/test.sh}" ]]; then source "${1:-$(dirname "$(realpath "$0")")/test.sh}"; else source "${1:-$(dirname "$(realpath "$0")")/run.sh}"; fi && set +e | ||
| run_test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tieske Is there more context on the motivation for this change? IIRC, the owner of kong files was changed to
kongfairly recently, so I am afraid of changing it back to root.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the original pr by Colin; Changing the ownership to root but giving the Kong user access prevents the Kong user from modifying the files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally, everything under a common shared path like
/usr/local/lib,/usr/local/shareshould always be owned byroot:rootbecause technically other packages will also write to it. this applies to also /etc/kong/kong.conf; only/usr/local/kong (and /usr/local/openresty, if we mark our package a conflict with
openresty) should be owned bykong:kong. (well, technically, even under/usr/local/kong, subdirs like/usr/local/kong/lib, /usr/local/kong/include` should be owned by root:root as well)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The course of action is IMO: